Metar URL in binary??!! What a rookie mistake!

Talking about the core development, vent steam ... censoring free but no guarantee, "they" will listen.
KL-666
Posts: 1610
Joined: Mon Sep 28, 2015 8:42 am

Metar URL in binary??!! What a rookie mistake!

Postby KL-666 » Wed Jul 13, 2016 6:49 pm

How on earth can someone bake a metar URL in an exe? What if the site changes it's structure? Go and make a new fg release? This is such a beginners mistake!

There is now an issue with the used URL:
http://weather.noaa.gov/pub/data/observ ... s/LFLP.TXT

I can get at the same with:
ftp://tgftp.nws.noaa.gov/data/observati ... s/LFLP.TXT

But i can not change it in the exe. This URL should have been in a configuration file. Data belongs outside executable binaries. The latter should only contain logic. Should i really take people that do not know how to adhere to simple coding principles as serious programmers?

To the brilliant and ever superior core developers: Please make a new fg release with the working metar URL in it, within an hour or so. Or better: A release with executables cleared from data.

Kind regards, Vincent

User avatar
legoboyvdlp
Posts: 1757
Joined: Mon Sep 14, 2015 9:49 pm
Location: Venezuela

Re: Metar URL in binary??!! What a rookie mistake!

Postby legoboyvdlp » Wed Jul 13, 2016 8:07 pm

seems to be working right now, at least with the URL.
Have not checked FG.
But yes, there was no METAR.
~~Legoboyvdlp~~
Maiquetia / Venezuela Custom Scenery
Hallo! Ich bin Jonathan.
Hey!
Avatar created by InSapphoWeTrust CC BY-SA 2.0, https://commons.wikimedia.org/w/index.p ... d=27409879

User avatar
IAHM-COL
Posts: 6409
Joined: Sat Sep 12, 2015 3:43 pm
Location: Homey, NV (KXTA) - U.S.A
Contact:

Re: Metar URL in binary??!! What a rookie mistake!

Postby IAHM-COL » Wed Jul 13, 2016 8:37 pm

A METAR transferred as binary? Makes no sense to me...

Regardless of it works right now.
https://raw.githubusercontent.com/IAHM-COL/gpg-pubkey/master/pubkey.asc

R.M.S.
If we gave everybody in the World free software today, but we failed to teach them about the four freedoms, five years from now, would they still have it?

KL-666
Posts: 1610
Joined: Mon Sep 28, 2015 8:42 am

Re: Metar URL in binary??!! What a rookie mistake!

Postby KL-666 » Wed Jul 13, 2016 8:56 pm

No, the url where fg gets metar from is compiled into a binary of fg. A url is data, and belongs in a config file or a database.

Kind regards, Vincent

Octal450
Posts: 2192
Joined: Sun Oct 18, 2015 2:47 am

Re: Metar URL in binary??!! What a rookie mistake!

Postby Octal450 » Thu Jul 14, 2016 3:21 am

I don't think that is right. It can't be binary.

Really stupid if they did that.

Josh

KL-666
Posts: 1610
Joined: Mon Sep 28, 2015 8:42 am

Re: Metar URL in binary??!! What a rookie mistake!

Postby KL-666 » Sat Aug 06, 2016 12:35 am

Well, they did just that. The url is baked into my fgfs.exe, instead of being in a settings file where data should be.

Kind regards, Vincent

Octal450
Posts: 2192
Joined: Sun Oct 18, 2015 2:47 am

Re: Metar URL in binary??!! What a rookie mistake!

Postby Octal450 » Sat Aug 06, 2016 1:05 am

Yup. no weather for me.

Fuck

KL-666
Posts: 1610
Joined: Mon Sep 28, 2015 8:42 am

Re: Metar URL in binary??!! What a rookie mistake!

Postby KL-666 » Mon Aug 08, 2016 10:55 pm

Ok, i hex-edited my fgfs.exe file, as per:

https://forum.flightgear.org/viewtopic.php?f=25&t=30136#p291851

It works for now. Have to fly a bit more with it. Anyone who fears hex-editing can download my fgfs.exe.

Be aware that it is:
1) A windows exe
2) Fg version 2016.1.1, 2016.1.2 or 2016.2.1

If you do not match that, you do not need to try.

2016.1.1 http://iveze.nl/data/fgfs1.zip
2016.1.2 http://iveze.nl/data/fgfs12.zip
2016.2.1 http://iveze.nl/data/fgfs.zip

Kind regards, Vincent
Last edited by KL-666 on Mon Aug 15, 2016 2:32 am, edited 2 times in total.

User avatar
IAHM-COL
Posts: 6409
Joined: Sat Sep 12, 2015 3:43 pm
Location: Homey, NV (KXTA) - U.S.A
Contact:

Re: Metar URL in binary??!! What a rookie mistake!

Postby IAHM-COL » Tue Aug 09, 2016 1:05 am

interesting alternative. I'm on linux, and with a git version. I'll pull and recompile... and then see where I end up.

I add my voice to KL666 position that the METAR URL should be in plain text over a config file. PERIOD.
This binary thing is a bit of a brain-crack.

IH-COL
https://raw.githubusercontent.com/IAHM-COL/gpg-pubkey/master/pubkey.asc

R.M.S.
If we gave everybody in the World free software today, but we failed to teach them about the four freedoms, five years from now, would they still have it?

Octal450
Posts: 2192
Joined: Sun Oct 18, 2015 2:47 am

Re: Metar URL in binary??!! What a rookie mistake!

Postby Octal450 » Tue Aug 09, 2016 3:13 am

I'll compile one for 2016.1.2 on Vindows.


Return to “Core Development”

Who is online

Users browsing this forum: No registered users and 8 guests